Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pybotvac to 0.0.25 #115435

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Bump pybotvac to 0.0.25 #115435

merged 1 commit into from
Apr 11, 2024

Conversation

Santobert
Copy link
Member

@Santobert Santobert commented Apr 11, 2024 •
edited
Loading

Breaking change

Proposed change

Bump pybotvac to fix a syntax warning with newer python versions: stianaske/pybotvac#85

See all changes here: stianaske/pybotvac@v0.0.24...v0.0.25

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Santobert Santobert changed the title Bump pybotvac Bump pybotvac to 0.0.25 Apr 11, 2024
joostlek
joostlek requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently my saved replies dont work, but please add a diff from one version to the other

@home-assistant home-assistant bot marked this pull request as draft April 11, 2024 18:12
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek
Copy link
Member

Also, @Santobert, this integration would benefit from using a coordinator because every entity is using the same call to update the state. I once wanted to add it but I dont have the device to test it, do you maybe have some time in the future to look at this?

@Santobert
Copy link
Member Author

@joostlek Done, thank you.

I may find time to do this, but honestly I don't see much use in it. Newer Neato devices no longer work with this integration and I expect the older devices to slowly die out until one day Neato disables the API.

@Santobert Santobert marked this pull request as ready for review April 11, 2024 19:47
@home-assistant home-assistant bot requested a review from joostlek April 11, 2024 19:47
@joostlek
Copy link
Member

joostlek commented Apr 11, 2024 •
edited
Loading

Keep in mind we currently do a request for every entity, so instead of requesting the same data for every integration it would cost them less if we only requested one time for every cycle. It would maybe help a bit.

@joostlek joostlek added this to the 2024.4.3 milestone Apr 11, 2024
@joostlek joostlek merged commit c14f11f into home-assistant:dev Apr 11, 2024
38 checks passed
frenck pushed a commit that referenced this pull request Apr 12, 2024
@Santobert @frenck
Bump pybotvac to 0.0.25 (#115435)
2ed1cfd 
Bump pybotvac
@frenck frenck mentioned this pull request Apr 12, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency integration: neato Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.4.3
Development

Successfully merging this pull request may close these issues.

Neato: SyntaxWarning: invalid escape sequence '\d'
3 participants
@Santobert @joostlek @frenck